Re: [Xen-devel] [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 02, 2016 at 11:38:30AM -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Jun 02, 2016 at 09:25:55AM -0600, Jan Beulich wrote:
> > >>> On 02.06.16 at 17:18, <konrad.wilk@xxxxxxxxxx> wrote:
> > > On Thu, Jun 02, 2016 at 03:58:37PM +0100, Andrew Cooper wrote:
> > >> On 02/06/16 15:50, Jan Beulich wrote:
> > >> >
> > >> >> --- a/xen/arch/arm/xsplice.c
> > >> >> +++ b/xen/arch/arm/livepatch.c
> > >> >> @@ -4,67 +4,67 @@
> > >> >>  #include <xen/errno.h>
> > >> >>  #include <xen/init.h>
> > >> >>  #include <xen/lib.h>
> > >> >> -#include <xen/xsplice_elf.h>
> > >> >> -#include <xen/xsplice.h>
> > >> >> +#include <xen/livepatch_elf.h>
> > >> >> +#include <xen/livepatch.h>
> > >> >>  
> > >> >> -void arch_xsplice_patching_enter(void)
> > >> >> +void arch_livepatching_enter(void)
> > >> > Still "patching"?
> > >> 
> > >> This function came from one of my additions to the series.  It half of a
> > >> pair of calls around the critical region which is writing new code/data,
> > >> where CR0.WP needs tweaking.
> > >> 
> > >> As such, 'patching' was logically distinct from the name 'livepatch' as
> > >> the general namespace of these functions, and referred to the critical
> > >> region of actually changing live memory.
> > >> 
> > >> I am at a loss to suggest a better alternative.
> > > 
> > >  arch_quiescing_start and arch_quiescing_stop ?
> > 
> > arch_livepatch_quiesce() / arch_livepatch_revive()?
> 
> Fantastic!
> 
> For reference the patch.
> 
> From c15659cf833a453c27386cb181744ebcf5b0cd1f Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Date: Wed, 1 Jun 2016 20:14:47 -0400
> Subject: [PATCH v3.1 for 4.7] xen: Rename of xSplice to livepatch.
> 
> Specifically:
> 
> s/\.xsplice/\.livepatch/
> s/XSPLICE/LIVEPATCH/
> s/xsplice/livepatch/
> s/livepatch_patch_func/livepatch_func/
> s/xSplice/Xen Live Patch/
> s/livepatching/livepatch/
> s/arch_livepatch_enter/arch_livepatch_quiesce/
> s/arch_livepatch_exit/arch_livepatch_revive/
> 
> And then modify some of the function arguments
> to have two more characters.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> ---
> Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Martin Pohlack <mpohlack@xxxxxxxxx>
> 
> v2: Ditch the LIVE_PATCH and 'Live Patching' inconsitency.
>     Include Ross's email correctly.
>     Don't move alphabetically the #include header as it is
>     inconsistent
> v3: s/livepatching/livepatch/
>     Alter some of the "live patching" or "live patch" to say
>     "Live Patch"
>     Move in common/Makefile the livepatch entry (it is sorted)
>     Move the LIVEPATCH in MAINTAINERS file in the proper location
>     (it is sorted). Add Jan's Ack.
> v3.1: s/arch_livepatch_enter/arch_livepatch_quiesce/
>     s/arch_livepatch_exit/arch_livepatch_revive/
> ---
>  .gitignore                                         |   8 +-
>  MAINTAINERS                                        |  20 +-
>  docs/misc/{xsplice.markdown => livepatch.markdown} | 184 +++++-----
>  tools/flask/policy/policy/modules/xen/xen.te       |   2 +-
>  tools/libxc/include/xenctrl.h                      |  32 +-
>  tools/libxc/xc_misc.c                              | 142 ++++----
>  tools/misc/Makefile                                |   4 +-
>  tools/misc/{xen-xsplice.c => xen-livepatch.c}      |  62 ++--

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

And

Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel