Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.06.16 at 13:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 02/06/16 12:34, Jan Beulich wrote:
>>>>> On 02.06.16 at 13:12, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> and a
>>> preemptive fix on the HVM side to avoid advertising any XSS states, as
>>> we don't support any yet.
>> I don't think I really like this part. What's wrong with keeping
>> things the way they are?
> 
> We currently blindly trust the toolstack-provided values for
> CPUID.7[1].ECX/EDX, which are the valid XSS bits.
> 
> Given that the bug trying to be fixed here is that Linux writes
> CPUID.7[0].EAX/EDX directly into %xcr0, I felt it prudent to make the
> same fix for XSS.

Oh, you're right - this is actually well in line with the rest of the
change. Keep it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel