Re: [Xen-devel] [PATCH v4 1/2] AMD IOMMU: Removing currently non-functioning guest iommu feature

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 02, 2016 at 04:43:32AM -0600, Jan Beulich wrote:
> >>> On 02.06.16 at 12:26, <wei.liu2@xxxxxxxxxx> wrote:
> > On Thu, Jun 02, 2016 at 03:55:41AM -0600, Jan Beulich wrote:
> >> >>> On 01.06.16 at 21:52, <suravee.suthikulpanit@xxxxxxx> wrote:
> >> > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> >> > 
> >> > The guest IOMMU feature is currently not functioning. However,
> >> > the current guest_iommu_init() is causing issue when it tries to
> >> > register mmio handler because the it is currently called by the
> >> > following code path:
> >> > 
> >> >   arch/x86/domain.c: arch_domain_create()
> >> >     ]- drivers/passthrough/iommu.c: iommu_domain_init()
> >> >       |- drivers/passthrough/amd/pci_amd_iommu.c: 
> >> > amd_iommu_domain_init();
> >> >         |- drivers/passthrough/amd/iommu_guest.c: guest_iommu_init()
> >> > 
> >> > At this point, the hvm_domain_initialised() has not been called.
> >> > So register_mmio_handler() in guest_iommu_init() silently fails.
> >> > 
> >> > This patch removes the guest IOMMU feature for now until we can properly
> >> > support it.
> >> > 
> >> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >> 
> >> Thanks, quite reasonable. And imo actually a 4.7 candidate. Wei?
> >> 
> > 
> > Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Please apply this series within this week.
> 
> Series? Also the other one, which is pretty benign imo?
> 

Yes, the other one as well. I thought it you wanted this whole series in.

But if you only want this one in, that's of course fine by me.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel