Re: [Xen-devel] [PATCH RESEND 1/4] libs, gnttab, libxc: Interface for grant copy operation

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, May 31, 2016 at 06:44:55AM +0200, Paulina Szubarczyk wrote:
> Implentation of interface to grant copy operation called through
> libxc. An ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is
> invoked for linux. In the mini-os the operation is yet not
> implemented.

Thanks for the patch! This (and other patches) seem to be missing a 
Signed-off-by tag. See:
 
http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signing_off_a_patch

> ---
>  tools/include/xen-sys/Linux/gntdev.h  | 21 ++++++++++
>  tools/libs/gnttab/gnttab_core.c       | 12 ++++++
>  tools/libs/gnttab/include/xengnttab.h | 18 +++++++++
>  tools/libs/gnttab/libxengnttab.map    |  2 +
>  tools/libs/gnttab/linux.c             | 72 
> +++++++++++++++++++++++++++++++++++
>  tools/libs/gnttab/minios.c            |  8 ++++
>  tools/libs/gnttab/private.h           |  6 +++
>  tools/libxc/include/xenctrl_compat.h  |  8 ++++
>  tools/libxc/xc_gnttab_compat.c        | 12 ++++++
>  9 files changed, 159 insertions(+)
> 
[...]
> index 7e04174..8c90227 100644
> --- a/tools/libs/gnttab/minios.c
> +++ b/tools/libs/gnttab/minios.c
> @@ -106,6 +106,14 @@ int osdep_gnttab_set_max_grants(xengnttab_handle *xgt, 
> uint32_t count)
>      return ret;
>  }
>  
> +int osdep_gnttab_grant_copy(xengnttab_handle *xgt,
> +                            uint32_t count,
> +                            uint16_t *domids, uint32_t *refs, void **bufs,
> +                            uint32_t *mem, uint32_t *len, int type, 
> +                            uint32_t notify_offset, evtchn_port_t 
> notify_port)
> +{
> +    return -1;
> +}

You should add some dummy helpers to tools/libs/gnttab/gnttab_unimp.c or 
else you will break the build for OSes that don't have a gnttab device.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel