[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 09/16] efi: explicitly define efi struct in xen/arch/x86/efi/stub.c
On Fri, May 27, 2016 at 02:16:09AM -0600, Jan Beulich wrote: > >>> On 25.05.16 at 18:45, <daniel.kiper@xxxxxxxxxx> wrote: > > On Wed, May 25, 2016 at 01:03:42AM -0600, Jan Beulich wrote: > >> >>> On 15.04.16 at 14:33, <daniel.kiper@xxxxxxxxxx> wrote: > >> > Existing solution does not allocate space for this symbol and any > >> > references to acpi20, etc. does not make sense. As I saw any efi.* > >> > references are protected by relevant ifs but we should not do that > >> > because it makes code very fragile. If somebody does not know how > >> > efi symbol is created he/she may assume that it always represent > >> > valid structure and do invalid references somewhere. > >> > >> I do not view this as a valid reason for the change. > > > > Why? > > Because there are no accesses to the structure in non-EFI builds? > Even if it's just a small table, I'm generally opposed to adding dead > code or data. I simply do not like the attitude of "memory is cheap" > these days. Following that model leads to quite a bit of useless I concur! > bloat. Plus no matter whether memory is cheap, cache and TLB > bandwidth are precious, and both may get pressure added by such > dead elements. OK, but in the future please add a few words of comment in such cases because it is not obvious why just looking at code. Daniel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |