Re: [Xen-devel] [PATCH v2] xen/arm: warn the user that we cannot route SPIs to Dom0 on ACPI

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/06/16 15:38, Stefano Stabellini wrote:
> as a consequence of 9d77b3c01d1261ce17c10097a1b393f2893ca657 being
> reverted.
>
> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Some style corrections.

> @@ -342,9 +344,22 @@ void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n)
>      unsigned long flags;
>      int i = 0;
>      struct vcpu *v_target;
> +    struct domain *d = v->domain;
>  
>      while ( (i = find_next_bit(&mask, 32, i)) < 32 ) {
>          irq = i + (32 * n);
> +        /* Set the irq type and route it to guest only for SPI and Dom0 */
> +        if( irq_access_permitted(d, irq) && is_hardware_domain(d) &&

Space after if.

> +            ( irq >= 32 ) && ( !acpi_disabled ) )

Extraneous spaces, and pointless brackets for the acpi_disabled.

> +        {
> +            static int log_once = 0;

bool_t.  Also, missing a newline between the variable declaration and code.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel