Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/06/16 11:54, Kang, Luwei wrote:
> Thank  you Andrew Cooper, this patch indeed resolve my issue and  two point 
> need modify.
>
> The code need  move ahead of "break;"
> @@ -1101,6 +1101,9 @@ void pv_cpuid(struct cpu_user_regs *regs)
>              if ( !is_control_domain(currd) && !is_hardware_domain(currd) )
>                  cpuid_count(leaf, subleaf, &tmp, &b, &tmp, &tmp);
>              break;
> +
> +            a &= (uint32_t)pv_xfeature_mask;
> +            d &= (uint32_t)(pv_xfeature_mask >> 32);
>          }

Ah of course.  That is quite a silly mistake on my behalf.

>
> extraneous space after "&".
> -    sanitise_featureset(hvm_featureset);
> +    sanitise_featureset(hvm_featureset, & hvm_xfeature_mask);

I had already spotted and fixed this.

I will collect all feedback and post a formal patch to the list.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel