[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxx>
- Date: Thu, 26 May 2016 11:14:44 +0100
- Cc: Juergen Gross <jgross@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Daniel Kiper <daniel.kiper@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, Julien Grall <julien.grall@xxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Delivery-date: Thu, 26 May 2016 10:15:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Hi Stefano,
On 16/05/2016 12:11, Stefano Stabellini wrote:
On Wed, 11 May 2016, Arnd Bergmann wrote:
A bugfix patch for the xen balloon driver introduced a forward
declaration for a static function that is conditionally compiled,
causing a warning if only the declaration but not the definition
are there:
drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared
'static' but never defined [-Werror=unused-function]
static void release_memory_resource(struct resource *resource);
This removes the declaration again and instead moves the function
definition to the right place, before its first caller and inside
of the #ifdef protecting both.
The patch that introduced the warning is marked for stable
backports, so if that gets applied to 4.4, so should this one.
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
You have applied this patch to the branch for-linus-4.8 but not
for-linus-4.7. Is it intentional?
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
