Re: [Xen-devel] [PATCH v5 05/10] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.05.16 at 10:08, <quan.xu@xxxxxxxxx> wrote:
> Propagate the IOMMU Device-TLB flush error up to IOMMU mapping.

Btw - there's little reason to repeat the title here.

> @@ -295,12 +297,23 @@ static void __hwdom_init amd_iommu_hwdom_init(struct 
> domain *d)
>               * a pfn_valid() check would seem desirable here.
>               */
>              if ( mfn_valid(pfn) )
> -                amd_iommu_map_page(d, pfn, pfn, 
> -                                   IOMMUF_readable|IOMMUF_writable);
> +            {
> +                int ret;
> +
> +                ret = amd_iommu_map_page(d, pfn, pfn,
> +                                         IOMMUF_readable|IOMMUF_writable);
> +
> +                if ( unlikely(ret) )
> +                    rc = ret;
> +            }

So you do the adjustment needed to add __must_check to
amd_iommu_map_page(), but you don't actually add the annotation.
Is there a reason for this?

And of course the comment to an earlier patch applies regarding
which error to return.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel