Re: [Xen-devel] [RFC] libxl hotplug / unplug emulated devices

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 20, 2016 at 06:58:40PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [RFC] libxl hotplug / unplug emulated devices"):
> > On Fri, May 20, 2016 at 05:38:44PM +0100, Ian Jackson wrote:
> > > Maybe the fix should be that xl network-attach should default hotplug
> > > nics to pv only.
> > 
> > Here is a patch to do this. :-)
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although I have a style nit:
> 
> >              if (libxl__device_model_version_running(gc, domid) ==
> > -                LIBXL_DEVICE_MODEL_VERSION_NONE)
> > +                LIBXL_DEVICE_MODEL_VERSION_NONE || hotplug)
> >                  nic->nictype = LIBXL_NIC_TYPE_VIF;
> 
> This is rather odd formatting.  It makes it look like
>    if (version = (NONE || hotplug)) { ...
> 

Perhaps you mean

     if ((version == NONE) || hotplug)

?

> You might prefer to put another line break, before the || perhaps.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel