Re: [Xen-devel] [PATCH v3 2/6] build: convert crash_debug to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 5/12/16 4:03 AM, Jan Beulich wrote:
>>>> On 11.05.16 at 19:35, <cardoe@xxxxxxxxxx> wrote:
>> On 5/11/16 4:47 AM, Jan Beulich wrote:
>>>>>> On 10.05.16 at 23:05, <cardoe@xxxxxxxxxx> wrote:
>>>> --- a/xen/Kconfig.debug
>>>> +++ b/xen/Kconfig.debug
>>>> @@ -1,6 +1,13 @@
>>>>  
>>>>  menu "Debugging Options"
>>>>  
>>>> +config CRASH_DEBUG
>>>> +  bool "Crash Debugging Support"
>>>> +  depends on X86
>>>> +  ---help---
>>>> +    If you want to be able to attach gdb to Xen to be able to debug
>>>> +    Xen if it crashes then say Y.
>>>> +
>>>>  config DEBUG
>>>>    bool "Developer Checks"
>>>>    ---help---
>>>
>>> Is this really meant to be independent of DEBUG (or EXPERT), as it's
>>> being placed ahead of DEBUG?
>>
>> That's what we talked about with v2. You wanted it to be independent if
>> EXPERT was set but when you have something defined as "menuconfig XXXX"
>> you cannot then have a rule "if XXXX || EXPERT" as you asked for in v2.
>> So I needed to make them independent always which is what I did.
>>
>> Let me restate more generically, if things are dependent on a menu for
>> the sub-menu items to be displayed (as in v2) then the menu must be
>> enabled and cannot be conditionally displayed on another option.
>>
>> Roughly think of it this way:
>>
>> menuconfig SOME_STATE
>>
>> if SOME_STATE || EXPERT
>>
>> config OTHER
>>
>> endif
>>
>>
>> is the following code:
>>
>>
>> if (SOME_STATE) {
>>   if (SOME_STATE or EXPERT) {
>>     printf("got here\n");
>>   }
>> }
> 
> But there's no menuconfig anymore, for precisely that reason (aiui).
> 
> Jan
> 

Right. That's what I was trying to get across. What I gathered from past
reviews is that it should to be independent of DEBUG correct?

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel