Re: [Xen-devel] [PATCH v9 12/27] xsplice: Implement support for applying/reverting/replacing patches.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, May 11, 2016 at 11:51:53AM +0200, Martin Pohlack wrote:
> On 27.04.2016 05:39, Konrad Rzeszutek Wilk wrote:
> [...]
> > +        /* "Mask" NMIs. */
> > +        arch_xsplice_mask();
> 
> You mask here ...
> 
> > +        barrier(); /* MUST do it after get_cpu_maps. */
> > +        cpus = num_online_cpus() - 1;
> > +
> > +        if ( cpus )
> > +        {
> > +            dprintk(XENLOG_DEBUG, XSPLICE "%s: CPU%u - IPIing the other %u 
> > CPUs\n",
> > +                    p->name, cpu, cpus);
> > +            smp_call_function(reschedule_fn, NULL, 0);
> > +        }
> > +
> > +        timeout = xsplice_work.timeout + NOW();
> > +        if ( xsplice_spin(&xsplice_work.semaphore, timeout, cpus, "CPU") )
> > +            goto abort;
> 
> ... and potentially abort here, but the abort path does not unmask, so
> you lose the NMI handler.

Ouch! Sending a patch shortly out! Thanks for spotting that

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel