Re: [Xen-devel] [PATCH] xsplice: Prevent new symbols duplicating core symbols

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 10, 2016 at 10:10:02AM +0100, Ross Lagerwall wrote:
> When loading patches, the code prevents loading a patch containing a new
> symbol that duplicates a symbol from another loaded patch. However, the
> check should also prevent loading a new symbol that duplicates a symbol
> from the core hypervisor.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> ---
> 
> Wei, can you consider this for 4.7? Thanks
> 

This looks like a valid and simple bug fix, I'm fine with this going
into 4.7.

Wei.

>  xen/common/xsplice.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
> index c9fc53a..21b9ec0 100644
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -748,7 +748,8 @@ static int build_symbol_table(struct payload *payload,
>  
>          if ( !found )
>          {
> -            if ( xsplice_symbols_lookup_by_name(symtab[i].name) )
> +            if ( symbols_lookup_by_name(symtab[i].name) ||
> +                 xsplice_symbols_lookup_by_name(symtab[i].name) )
>              {
>                  dprintk(XENLOG_ERR, XSPLICE "%s: duplicate new symbol: %s\n",
>                          elf->name, symtab[i].name);
> -- 
> 2.4.11
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel