Re: [Xen-devel] [PATCH v10 21/24] xsplice: Stacking build-id dependency checking.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.04.16 at 21:27, <konrad.wilk@xxxxxxxxxx> wrote:
> @@ -506,6 +518,37 @@ static int prepare_payload(struct payload *payload,
>          }
>      }
>  
> +    sec = xsplice_elf_sec_by_name(elf, ELF_BUILD_ID_NOTE);
> +    if ( sec )
> +    {
> +        n = sec->load_addr;
> +
> +        if ( sec->sec->sh_size <= sizeof(*n) )
> +            return -EINVAL;
> +
> +        if ( xen_build_id_check(n, sec->sec->sh_size,
> +                                &payload->id.p, &payload->id.len) )
> +            return -EINVAL;
> +
> +        if ( !payload->id.len || !payload->id.p )
> +            return -EINVAL;
> +    }
> +
> +    sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS);
> +    {

Looks like an "if ( sec )" got lost here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel