Re: [Xen-devel] [PATCH v10 22/24] xsplice/xen_replace_world: Test-case for XSPLICE_ACTION_REPLACE

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.04.16 at 21:27, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/test/Makefile
> +++ b/xen/arch/x86/test/Makefile
> @@ -7,15 +7,18 @@ CODE_SZ=$(shell nm --defined -S $(1) | grep $(2) | awk '{ 
> print "0x"$$2}')
>  
>  XSPLICE := xen_hello_world.xsplice
>  XSPLICE_BYE := xen_bye_world.xsplice
> +XSPLICE_REPLACE := xen_replace_world.xsplice
>  
>  default: xsplice
>  
>  install: xsplice
>       $(INSTALL_DATA) $(XSPLICE) $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE)
>       $(INSTALL_DATA) $(XSPLICE_BYE) $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE_BYE)
> +     $(INSTALL_DATA) $(XSPLICE_REPLACE) 
> $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE_REPLACE)
>  uninstall:
>       rm -f $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE)
>       rm -f $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE_BYE)
> +     rm -f $(DESTDIR)$(DEBUG_DIR)/$(XSPLICE_REPLACE)
>  
>  .PHONY: clean
>  clean::

Note how you (not using *.xsplice there) forget to clean the new
binary here?

> @@ -73,6 +76,13 @@ $(XSPLICE_BYE): $(XSPLICE) config.h xen_bye_world_func.o 
> xen_bye_world.o hello_w
>       $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(XSPLICE_BYE) \
>               $(filter %.o,$^)
>  
> +xen_replace_world.o: config.h
> +
> +.PHONY: $(XSPLICE_REPLACE)
> +$(XSPLICE_REPLACE): config.h xen_replace_world_func.o xen_replace_world.o 
> note.o
> +     $(LD) $(LDFLAGS) $(build_id_linker) -r -o $(XSPLICE_REPLACE) \
> +             $(filter %.o,$^)

Same here again: Ack with suitable adjustments.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel