Re: [Xen-devel] [PATCH] MAINTAINERS: Clarify the meaning of nested maintainership

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 26/04/16 17:57, Lars Kurth wrote:
> 
> 
> On 26/04/2016 17:19, "George Dunlap" <george.dunlap@xxxxxxxxxx> wrote:
> 
>> On 21/04/16 17:59, Lars Kurth wrote:
>>>
>>>
>>> On 21/04/2016 17:03, "George Dunlap" <george.dunlap@xxxxxxxxxx> wrote:
>>>
>>>> Clarify the meaning of nested maintainership.
>>>>
>>>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>>>> ---
>>>>
>>>> MAINTAINERS | 34 ++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 34 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index a34685d..be901d5 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -94,6 +94,40 @@ Descriptions of section entries:
>>>>          printk, pr_info or pr_err
>>>>       One regex pattern per line.  Multiple K: lines acceptable.
>>>>
>>>> +
>>>> +The meaning of nesting:
>>>> +
>>>>
>>>> [snip]
>>>
>>>> + - In the case of a disagreement between maintainers, THE REST can
>>>> + vote to settle the matter.  (This should be very exceptional indeed.)
>>>
>>> This creates a slight conflict with the project governance, which states
>>> that committers act as referees in case of disagreements. As REST
>>> maintainers are a superset of committers, this could create a potential
>>> mismatch.
>>>
>>> Given, that the text says "can", I don't have an issue with it. It
>>> merely
>>> adds an extra level of complexity when it comes to resolving
>>> disagreements
>>> and maybe could be confusing.
>>
>> With Keir gone, is that actually the case anymore?  I think at the
>> moment REST == committers.
>>
>> And the logic behind putting the committers under the REST seemed to me
>> in part to make the logic match up.
> 
> That is fine with me. I just picked up on it, because further up the patch
> you said
> 
> +Many maintanership areas are "nested": for example, there are entries
> +for xen/arch/x86 as well as xen/arch/x86/mm, and even
> +xen/arch/x86/mm/shadow; and there is a section at the end called "THE
> +REST" which lists all committers, as well as a few more.

OK -- I'll modify that, and put a note to be discussed in the resubmission.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel