Re: [Xen-devel] [PATCH] delte PAGE_ORDER_1G in pod

["Zhang, Chunyu" <zhangcy@xxxxxxxxxxxxxx>]

>>>> On 26.04.16 at 09:27, <zhangcy@xxxxxxxxxxxxxx> wrote:
>> PoD does not have cache list for 1GB pages.
>
>But it might gain support in the future. Is there any harm in this code
>being there?
no harm in this code.
when i read this code, i wonder why order == PAGE_ORDER_1G?
this make me confuse.
i just delete useless code.

thanks 
>
>Jan
>
>> Signed-off-by: zhangcy <zhangcy@xxxxxxxxxxxxxx>
>> ---
>>  xen/arch/x86/mm/p2m-pod.c | 4 ----
>>  1 file changed, 4 deletions(-)
>> 
>> diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c
>> index a931f2c..89a07ee 100644
>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -122,10 +122,6 @@ p2m_pod_cache_add(struct p2m_domain *p2m,
>>      /* Then add to the appropriate populate-on-demand list. */
>>      switch ( order )
>>      {
>> -    case PAGE_ORDER_1G:
>> -        for ( i = 0; i < (1UL << PAGE_ORDER_1G); i += 1UL << PAGE_ORDER_2M )
>> -            page_list_add_tail(page + i, &p2m->pod.super);
>> -        break;
>>      case PAGE_ORDER_2M:
>>          page_list_add_tail(page, &p2m->pod.super);
>>          break;
>> -- 
>> 1.7.12.4
>
>
>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel