Re: [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2016-04-13 at 17:31 -0600, Jim Fehlig wrote:
> > On Tue, Apr 12, 2016 at 10:31 PM, Jim Fehlig <jfehlig@xxxxxxxx>
> > wrote:
> > > 
> I'll knock up a patch to set the LIBXL_API_VERSION to 0x040200. The
> only APIs
> that have changed since 0x040200 are libxl_set_vcpuaffinity and
> libxl_domain_create_restore, but libvirt does not use the changes
> (added
> params). 
>
I think this is a good choice.

> libvirt does use new libxl APIs added since Xen 4.2, but those aren't
> tied to a specific LIBXL_API_VERSION.
> 
And, in those cases, usage should be gated by the appropriate
LIBXL_HAVE_FOOBAR symbol, which I see in the sources (e.g.,
for LIBXL_HAVE_NO_SUSPEND_RESUME or LIBXL_HAVE_DOMAIN_NODEAFFINITY) to
be the case, so good again. :-)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel