Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 11, 2016 at 11:54:06AM +0100, Wei Liu wrote:
> On Sun, Apr 10, 2016 at 10:14:46PM +0200, Samuel Thibault wrote:
> > Hello,
> > 
> > > > > > +    if (prod - out_cons >= XENFB_OUT_RING_LEN) {
> > > > > > +        return;
> > > > > > +    }
> > 
> > This test seems overzealous to me: AIUI, the producer can produce
> > XENFB_OUT_RING_LEN events, and thus prod - out_cons is exactly
> > XENFB_OUT_RING_LEN, i.e. there is no room left at all.
> > 
> > The frontend part is:
> > 
> >    while (page->out_prod - page->out_cons == XENFB_OUT_RING_LEN)
> >         schedule();
> > 
> > I.e. it waits while the buffer is exactly full.
> > 
> > So it seems to me the bug is at the backend side.
> > 
> 
> OK, thanks for checking!
> 
> Hudong, can you try the following diff?
  ^ Xudong

Sorry for the typo...

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel