Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 08, 2016 at 04:16:46PM +0200, Olaf Hering wrote:
> > > +        goto out;
> > > +
> > > +    tmp = libxl__xs_read(gc, t, GCSPRINTF("%s/%s/backend-id", fe_path, 
> > > dir));
> > > +    if (!tmp)
> > > +        goto out;
> > > +    ctrl->backend_domid = atoi(tmp);
> > 
> > Please sanitise input coming from frontend.  You need to check if the
> > backend domid and frontend domid make sense.
> 
> What do you have in mind? Something like in vusb_be_from_xs_fe?
> 

Yes.


Wei.

> Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel