Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU 
parameter for RTDS"):
> On Wed, Apr 06, 2016 at 03:55:25PM +0100, Ian Jackson wrote:
> > libxl.c: In function 'sched_rtds_vcpu_get':
> > libxl.c:5980:5: error: implicit declaration of function 
> > 'xc_sched_rtds_vcpu_get' [-Werror=implicit-function-declaration]
> > libxl.c: In function 'sched_rtds_vcpu_set':
> > libxl.c:6088:5: error: implicit declaration of function 
> > 'xc_sched_rtds_vcpu_set' [-Werror=implicit-function-declaration]
> 
...
> I could have fixed this for you, but I think it would be useful to you
> if you address this problem.
> 
> I suggest you:
> 
> 1. Fold in Reviewed-by and Acked-by tags to your patches.
> 2. Rebase these three patches on top of staging branch.
> 3. Use the following rune to build test every single commit and fix the
>    problem if it fails.
>    
>    $ git rebase -i HEAD~3 --exec "make -j4 clean && ./configure && \
>         make -j4 dist"
> 
> It will stop rebasing if one commit doesn't build. This is what I
> normally do when developing.
> 
> Note that the deadline for applying patches is Friday, so if you can
> refresh this by tomorrow that would be good.

Dario points out on irc that perhaps the problem is that I didn't
apply 2/4.  I wasn't CC'd on 2/4, so I foolishly assumed it was a
hypervisor patch (and the HV parts are already in tree).

I will check my view of the xen-devel list.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel