Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

[David Vrabel <dvrabel@xxxxxxxxxx>]

On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
> 
> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx 
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> ---
>  arch/arm/xen/enlighten.c         |    6 ++++++
>  arch/x86/xen/enlighten.c         |    7 +++++++
>  drivers/xen/events/events_fifo.c |    6 ++++++
>  3 files changed, 19 insertions(+)
> 
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
>                               unsigned long action,
>                               void *hcpu)
>  {
> +     /*
> +      * Xen guests do not offline/online CPUs during
> +      * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> +      * are not considered.
> +      */

This may not be true for arm guests.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel