Re: [Xen-devel] [PATCH] xen: enable per-VCPU parameter for RTDS

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 05/04/16 08:57, Jan Beulich wrote:
>>>> On 05.04.16 at 03:07, <lichong659@xxxxxxxxx> wrote:
>> Commit f7b87b0745b4 ("enable per-VCPU parameter for RTDS") introduced
>> a bug: it made it possible, in Credit and Credit2, when doing domain
>> or vcpu parameters' manipulation, to leave the hypervisor with a
>> spinlock held and interrupts disabled.
>>
>> Fix it.
>>
>> Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
>>
>> Acked-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> This appears to be the 3rd variant of the patch, all with the same
> bogus subject, and no versioning information at all. Please
> remember that mails can arrive out of order, so there's no way
> to reliably tell which one got sent first. So for this to go in I'm
> expecting you to re-send with a proper subject and an indication
> that this is not the initial version of the patch.

And since this version of the patch is functionally different than the
one Dario acked, you should drop his Acked-by as well.

Thanks for being responsive in fixing this bug; and sorry for all the
criticism, but OSS development is very detail-oriented, and it takes a
while to internalize all the rules for how things should be done.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel