Re: [Xen-devel] [PATCH V7 1/3] x86/xsaves: fix overwriting between non-lazy/lazy xsaves

[Shuai Ruan <shuai.ruan@xxxxxxxxxxxxxxx>]

On Mon, Apr 04, 2016 at 09:51:56AM -0600, Jan Beulich wrote:
> >>> On 31.03.16 at 10:57, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> > xsaves will not be used until supervised state is introduced in hypervisor.
> > And XSTATE_XSAVES_ONLY (indicates supervised state is understood in xen)
> > is instroduced, the use of xsaves depend on whether XSTATE_XSAVES_ONLY
> 
> There's still a spelling mistake here, despite me having pointed it out
> before (you fixed one instance, but not the other). This could be
> dealt with upon commit, though.
Oh . "instroduced" :(
> 
> > is set in xcr0_accum.
> 
> Btw, I think this shouldn't be a #define, as it can - afaict - be derived
> from CPUID output. 
Ok.
>But this can easily be a follow-up patch, even one
> that doesn't make it into 4.7.
I do not understand your meaning clearly.
Do you mean the follow-up patch ( XSTATE_XSAVES_ONLY derived from cpuid)
will not into 4.7 ? If so, when is best/proper time to send out the
follow-up patch ? I am not sure whether add the follow-up patch in this 
patchset or in a sperate patch which one is ok ?
In either case I will keep working on this.
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
Thanks. I will send out V8 soon.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel