Re: [Xen-devel] [PATCH v5 5/9] x86/paravirt: Add _safe to the read_msr and write_msr PV hooks

[Borislav Petkov <bp@xxxxxxxxx>]

On Sat, Apr 02, 2016 at 07:01:36AM -0700, Andy Lutomirski wrote:
> These hooks match the _safe variants, so name them accordingly.
> This will make room for unsafe PV hooks.
> 
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/paravirt.h       | 33 +++++++++++++++++----------------
>  arch/x86/include/asm/paravirt_types.h |  8 ++++----
>  arch/x86/kernel/paravirt.c            |  4 ++--
>  arch/x86/xen/enlighten.c              |  4 ++--
>  4 files changed, 25 insertions(+), 24 deletions(-)

...

> diff --git a/arch/x86/include/asm/paravirt_types.h 
> b/arch/x86/include/asm/paravirt_types.h
> index 77db5616a473..5a06cccd36f0 100644
> --- a/arch/x86/include/asm/paravirt_types.h
> +++ b/arch/x86/include/asm/paravirt_types.h
> @@ -155,10 +155,10 @@ struct pv_cpu_ops {
>       void (*cpuid)(unsigned int *eax, unsigned int *ebx,
>                     unsigned int *ecx, unsigned int *edx);
>  
> -     /* MSR, PMC and TSR operations.
> -        err = 0/-EFAULT.  wrmsr returns 0/-EFAULT. */
> -     u64 (*read_msr)(unsigned int msr, int *err);
> -     int (*write_msr)(unsigned int msr, unsigned low, unsigned high);
> +     /* MSR operations.
> +        err = 0/-EIO.  wrmsr returns 0/-EIO. */

Please reformat this comment properly, while you're at it:

        /*
         * A sentence.
         * Another sentence.
         */

> +     u64 (*read_msr_safe)(unsigned int msr, int *err)Please reformat this
> comment properly, while you're at it:
> +     int (*write_msr_safe)(unsigned int msr, unsigned low, unsigned high);
>  
>       u64 (*read_pmc)(int counter);
>  

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel