Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("[PATCH v3 5/9] libxl: Rearrange qemu upstream disk 
argument code"):
> Reorganize the qemuu disk argument code to make a clean separation
> between finding a file to use, and constructing the parameters:
> 
> * Rename pdev_path to target_path
> 
> * Only use qemu_disk_format_string() in circumstances where qemu may
> be interpreting the disk (i.e., backend==QDISK).  In all other cases,
> it should use RAW.
> 
> * Share as much as possible between the is_cdrom path and the normal
> path.
> 
> This is mainly prep for sharing the local path finder with the
> bootloader; but it does allow cdroms to use any backend that a normal
> disk can use. Previously this was limited to RAW files or things that
> qemu could handle directly; as of this changeset, it now includes tap
> disks; and in future changesets it will include backends with custom
> block scripts.
> 
> NB that this retains an existing bug, that disks with custom block
> scripts or non-dom0 backends will have the bogus pdev_path passed in
> to qemu, most likely resulting in qemu exiting with an error.  This
> will be fixed in follow-up patches.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> Changes since v1:
> - Move qemuu disk argument refactoring into a separate patch

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

However, I think that this is going to have a conflict with the colo
series...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel