Re: [Xen-devel] [PATCH v9 for Xen 4.7 4/4] xl: enable per-VCPU parameter for RTDS

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 01, 2016 at 03:15:18PM +0200, Dario Faggioli wrote:
> On Thu, 2016-03-31 at 23:59 -0500, Chong Li wrote:
> > Change main_sched_rtds and related output functions to support
> > per-VCPU settings.
> > 
> > Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
> > Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> > Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> This Acked-by, I'm should have been removed. In fact, Wei sai it was
> subject to me saying Acked-by or Reviewed-by myself to v8. I did not
> say anything like that, and in fact I asked for changes, and Wei said
> himself that, at least some of those were necessary.
> 
> Now, you've addressed those comments, and I'm happy about how the patch
> is looking now, so:
> 
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> But I really think Wei (or Ian) should (re-)look and (re-)Ack.
> 

I'm happy with this patch, too. So

  Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> I've found only a couple of style issues. I don't feel like blocking
> the series or asking to resend... perhaps they can be fixed during
> commit? Or I'm up for sending a cleanup patch myself (which would not
> introduce any functional change), as soon as this hit the repo.
> 

IMHO a separate patch is better. Adjusting during committing in such
large patch is error prone, plus there is huge backlog to be applied at
the moment.

Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel