Re: [Xen-devel] [PATCH v8 for Xen 4.7 2/4] libxc: enable per-VCPU parameter for RTDS

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2016-03-18 at 16:26 -0500, Chong Li wrote:
> Add xc_sched_rtds_vcpu_get/set functions to interact with
> Xen to get/set a domain's per-VCPU parameters.
> 
> Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
> Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
> 
> ---
> Changes on PATCH v6:
> 1) Resolve some coding sytle issues
> 
You did not mention any chage since v7, but it looks like you did the
changes I suggested.

That should have been mentioned, if only, to help people figuring out
that it's the only thing that actually changed.

Also, Wei said:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

And I said that, if you fixed the pointless initialization of rc, you
could add:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

I think both still applies. Maybe it was ok to neglect Wei's Ack, since
you changed the subject line, which is important. But you should say
so, and catch his attention on this, so he can re-Ack the patch (if he
wants).

My tag, for sure, still applies, as I explicitly said so, and so you
should have put it in this version, to speedup review/commit.

In any case, I'm re-issueing it:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Please, stick it below the S-o-b tags in next version.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel