Re: [Xen-devel] [PATCH v4 20/26] tools/libxc: Modify bitmap operations to take void pointers

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Mar 23, 2016 at 04:36:23PM +0000, Andrew Cooper wrote:
> The type of the pointer to a bitmap is not interesting; it does not affect the
> representation of the block of bits being pointed to.
> 
> Make the libxc functions consistent with those in Xen, so they can work just
> as well with 'unsigned int *' based bitmaps.
> 
> As part of doing so, change the implementation to be in terms of char rather
> than unsigned long.  This fixes alignment concerns with ARM.

If you could, please also modify the comment in xc_misc.c. See

 3cab67ac83b1d56c3daedd9c4adfed497a114246
    libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement 
xc_cpumap_alloc.

Otherwise: Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel