Re: [Xen-devel] [PATCH v5 02/28] libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION hypercall

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 24, 2016 at 04:00:14PM -0400, Konrad Rzeszutek Wilk wrote:
[...]
> +
> +static int libxl__xc_version_wrapper(libxl__gc *gc, unsigned int cmd, char 
> *buf, ssize_t len, char **dst)

Please wrap this long line.

> +{
> +    int r;
> +
> +    r = xc_version(CTX->xch, cmd, buf, len);
> +    if ( r == -EPERM )
> +    {
> +        buf[0] = '\0';
> +    }
> +    else if ( r < 0 )
> +    {
> +        return r;
> +    }

      if (r == -EPERM) {
          buf[0] = '\0';
      } else if (r < 0) {
          return r;
      }


You seem to have mixed different coding styles ...

With those nits fixed:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel