Re: [Xen-devel] [PATCH v6 17/22] arm/gic: Add a new callback to deny Dom0 access to GIC regions

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shannon,

On 24/03/16 15:03, Shannon Zhao wrote:
> On 2016年03月24日 20:45, Stefano Stabellini wrote:
> > On Tue, 22 Mar 2016, Julien Grall wrote:
> > > > > > @@ -809,6 +835,10 @@ static u32 gicv2_make_hwdom_madt(const struct domain
> > > > > > *d, u32 offset)
> > > > > >    {
> > > > > >        return 0;
> > > > > >    }
> > > > > > +static int gicv2_iomem_deny_access(const struct domain *d)
> > > > > > +{
> > > > > > +    return 0;
> > > > > > +}
> > > > I don't see any benefits to have iomem_deny_access only implemented when
> > > > CONFIG_ACPI is built.
> > > >
> > > > Because in this case, you will also deny the iomem when Xen is booting using
> > > > device tree.
> > That's true, it would be better to do that for device tree too.
> Ok, I'll move it out of the CONFIG_ACPI. But calling it for device tree
> would be another patch I think.
Oh right. However my point is this function is not ACPI specific at all. 
So there is no need to compile out when ACPI is disabled.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel