Re: [Xen-devel] [PATCH v4 07/34] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.03.16 at 12:17, <julien.grall@xxxxxxx> wrote:
> Hi Jan,
> 
> On 23/03/16 08:19, Jan Beulich wrote:
>>>>> On 22.03.16 at 21:18, <konrad.wilk@xxxxxxxxxx> wrote:
>>> +    symbols_lookup_t *symbols_lookup;
>>> +
>>> +    struct {
>>> +        const struct bug_frame *bugs; /* The pointer to array of bug
>>> frames. */
>>> +        ssize_t n_bugs;         /* The number of them. */
>>> +    } frame[BUGFRAME_NR];
>>> +
>>> +#ifdef CONFIG_X86
>>> +    struct exception_table_entry *ex;
>>> +    struct exception_table_entry *ex_end;
>>> +#endif
>>
>> Would there be any harm omitting the #ifdef and leaving the
>> pointers be NULL on ARM?
> 
> The structure exception_table_entry is only defined for x86 
> (asm-x86/uaccess.h).

But the uses above are fine without the structure ever getting
defined.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel