Re: [Xen-devel] [V5] x86/xsaves: fix overwriting between non-lazy/lazy xsaves

[Shuai Ruan <shuai.ruan@xxxxxxxxxxxxxxx>]

On Wed, Mar 23, 2016 at 04:21:32AM -0600, Jan Beulich wrote:
> >>> On 23.03.16 at 07:14, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> > But for hvm_vcpu_reset_state(), I think we should deleting the code
> > initializing the xcomp_bv as said below.
> >> For hvm_vcpu_reset_state(), we should depend on whether xsaves is used 
> >> to decide whether to init xcomp_bv or not. And currently we use
> >> xcr0_accum to indicate the use of xsaves, when hvm_vcpu_reset_state()
> >> is called , can vcpu->xcr0_accum indicate using of xsaves ?
> >> I think in hvm_vcpu_reset_state(), we should leave xcomp_bv zero.
> 
> Leaving it to be zero would be fine, but is it guaranteed to be
> zero?
Oh, yeah, I will add v->arch.xsave_area->xsave_hdr.xcomp_bv = 0 in 
hvm_vcpu_reset_state() to guarante that.
> > A now wapper is intruduced as "_XRSTOR"( maybe the macro name is not
> > good ). 
> 
> Indeed an underscore followed by an uppercase letter is starting
> a reserved identifier. Maybe DO_XRSTOR() or _xrstor()?
> 
Really thanks for your suggestion. I will use _xrstor().

> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel