Re: [Xen-devel] [PATCH v3 03/28] xen/public: Export cpu featureset information in the public API

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/03/16 08:32, Konrad Rzeszutek Wilk wrote:
>
>> +
>> +/* Intel-defined CPU features, CPUID level 0x00000001.ecx, word 1 */
> This is quite the redefinition of the x86_capability[] array.
>
> As in if folks look at this from Linux and Xen there is quite
> a change.

Why does it matter?  People using the API get appropriate constants to
use, and it still functions the same.

> Could you address why we can't use the existing placement
> of these bits?

The existing placement has holes in the array, and Xen-specific
synthetic leaves, both of which are inappropriate in a new API/ABI.

The ABI is now formed of Intel-specified and AMD-specified leaves only,
with the Xen synthetic leaves on the end, and no holes.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel