Re: [Xen-devel] [PATCH 1/5] public/xen.h: add flags field to vcpu_time_info

[Joao Martins <joao.m.martins@xxxxxxxxxx>]

On 03/21/2016 03:27 PM, Andrew Cooper wrote:
> On 21/03/16 15:10, Jan Beulich wrote:
>>>>> On 17.03.16 at 17:12, <joao.m.martins@xxxxxxxxxx> wrote:
>>> --- a/xen/include/public/xen.h
>>> +++ b/xen/include/public/xen.h
>>> @@ -614,10 +614,14 @@ struct vcpu_time_info {
>>>       */
>>>      uint32_t tsc_to_system_mul;
>>>      int8_t   tsc_shift;
>>> -    int8_t   pad1[3];
>>> +    int8_t   flags;
>> For use as flags I'm sure this would better be uint8_t.
> 
> Sadly not possible.  Linux have already made the above adjustment
> without (CC'ing xen-devel), so that ABI is set.
> 
I was double checking again and it's my mistake. Both flags and pad fields are
uint8_t. I will fix both in v2, to make sure it's all kept the same on both
header files. My apologies.

Joao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel