Re: [Xen-devel] [PATCH v3 09/28] xen/x86: Calculate maximum host and guest featuresets

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.16 at 16:35, <andrew.cooper3@xxxxxxxxxx> wrote:
> +static void __init calculate_hvm_featureset(void)
> +{
> +    unsigned int i;
> +    const uint32_t *hvm_featuremask;
> +
> +    if ( !hvm_enabled )
> +        return;
> +
> +    hvm_featuremask = hvm_funcs.hap_supported ?
> +        hvm_hap_featuremask : hvm_shadow_featuremask;

I know I asked about this before, and it still puzzles me. Could you
add some explanation of this to the commit message or a comment?

> +    for ( i = 0; i < FSCAPINTS; ++i )
> +        hvm_featureset[i] = host_featureset[i] & hvm_featuremask[i];
> +
> +    /* Unconditionally claim to be able to set the hypervisor bit. */
> +    __set_bit(X86_FEATURE_HYPERVISOR, hvm_featureset);
> +
> +    /*
> +     * Allow the toolstack to set HTT and CMP_LEGACY.  These bits affect how
> +     * to interpret topology information in other cpuid leaves.
> +     */
> +    __set_bit(X86_FEATURE_HTT, pv_featureset);
> +    __set_bit(X86_FEATURE_CMP_LEGACY, pv_featureset);

Copy-n-paste mistake again (pv feature set in hvm function)?

With these taken care of
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel