Re: [Xen-devel] [PATCH v11 14/27] secondary vm suspend/resume/checkpoint code

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 17, 2016 at 05:03:12PM +0800, Changlong Xie wrote:
> On 03/05/2016 01:11 AM, Ian Jackson wrote:
> >Changlong Xie writes ("[PATCH v11 14/27] secondary vm 
> >suspend/resume/checkpoint code"):
> >>From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> >>
> >>Secondary vm is running in colo mode. So we will do
> >>the following things again and again:
> >
> >I don't propose to review this in detail.  Skimreading it, it looks
> >plausible.  I don't think a detailed review is needed.
> >
> >I will review the changes to the core code.
> >
> >>diff --git a/tools/libxc/xc_sr_common.h b/tools/libxc/xc_sr_common.h
> >>index 5d9f497..2bfed64 100644
> >>--- a/tools/libxc/xc_sr_common.h
> >>+++ b/tools/libxc/xc_sr_common.h
> >>@@ -184,10 +184,12 @@ struct xc_sr_context
> >>       * migration stream
> >>       * 0: Plain VM
> >>       * 1: Remus
> >>+     * 2: COLO
> >>       */
> >>      enum {
> >>          MIG_STREAM_NONE, /* plain stream */
> >>          MIG_STREAM_REMUS,
> >>+        MIG_STREAM_COLO,
> >
> >I think this shows that the duplicated list (in the comment, above the
> >enum) is a mistake.  I would prefer it to be removed.
> 
> We've sent out a patch to fix this issue first and wonder it can be merged,
> so we can rebase to it.
> 
> http://www.gossamer-threads.com/lists/xen/devel/423093
> 
> Thanks
>       -Xie

They will be committed today.

Sorry for the delay!

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel