Re: [Xen-devel] [PATCH v6 19/22] hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2016/3/17 18:42, Jan Beulich wrote:
>>>> On 17.03.16 at 10:41, <zhaoshenglong@xxxxxxxxxx> wrote:
>> > --- a/xen/include/public/hvm/params.h
>> > +++ b/xen/include/public/hvm/params.h
>> > @@ -49,11 +49,24 @@
>> >   * Domain = val[47:32], Bus = val[31:16] DevFn = val[15:8], IntX = 
>> > val[1:0]
>> >   */
>> >  
>> > +#ifndef CONFIG_ARM
> This is a public header, so you can't rely on CONFIG_* values.
> You should check compiler defined CPU architecture manifest
> constants instead (and there are numerous examples throughout
> public/).
Oh, right, thanks. Will replace it with
#if !defined(__arm__) && !defined (__aarch64__)

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel