[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11 10/27] tools/libxl: add back channel support to write stream
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
- From: Changlong Xie <xiecl.fnst@xxxxxxxxxxxxxx>
- Date: Thu, 17 Mar 2016 16:11:42 +0800
- Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jiang Yunhong <yunhong.jiang@xxxxxxxxx>, Dong Eddie <eddie.dong@xxxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx>, Shriram Rajagopalan <rshriram@xxxxxxxxx>, Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
- Delivery-date: Thu, 17 Mar 2016 08:09:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 03/05/2016 01:00 AM, Ian Jackson wrote:
Changlong Xie writes ("[PATCH v11 10/27] tools/libxl: add back channel support to
write stream"):
From: Wen Congyang <wency@xxxxxxxxxxxxxx>
Add back channel support to write stream. If the write stream is
a back channel stream, this means the write stream is used by
Secondary to send some records back.
The general idea seems fine to me but I want an opinion from Andrew.
If I'm not mistaken there is no call site for this yet. In which case
this should be mentioned in the commit message.
ok
Thanks
-Xie
+/*----- checkpoint state -----*/
+void libxl__stream_write_checkpoint_state(libxl__egc *egc,
+ libxl__stream_write_state *stream,
+ libxl_sr_checkpoint_state *srcs)
Firstly, missing blank line.
Secondly, reading all this leads me to think that maybe the
`checkpoint_state' record should be called something different. Is it
only ever going to be used for COLO ? Maybe it should be
`COLOHA_STATE' or something (and all the functions etc. renamed
consequently) ?
What do you think ?
Thanks,
Ian.
.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
