[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11 04/27] tools/libxl: Introduce new helper function dup_fd_helper()
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
- From: Changlong Xie <xiecl.fnst@xxxxxxxxxxxxxx>
- Date: Thu, 17 Mar 2016 16:08:16 +0800
- Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jiang Yunhong <yunhong.jiang@xxxxxxxxx>, Dong Eddie <eddie.dong@xxxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx>, Shriram Rajagopalan <rshriram@xxxxxxxxx>, Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
- Delivery-date: Thu, 17 Mar 2016 08:06:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 03/05/2016 12:42 AM, Ian Jackson wrote:
Changlong Xie writes ("[PATCH v11 04/27] tools/libxl: Introduce new helper function
dup_fd_helper()"):
From: Wen Congyang <wency@xxxxxxxxxxxxxx>
It is pure refactoring and no functional changes.
...
/*----- helper execution -----*/
+static int dup_fd_helper(libxl__gc *gc, int fd, const char *what)
+{
This is a fine thing to do. But the function name is less than
informative. I think I would call it something like `dup_cloexec'.
ok
The use of the term `helper' here is particularly confusing because it
also refers to the `save helper' of which this is part.
And
- missing newline after the /*---*/ comment
- this function should have a doc comment saying it cannot fail
ok, will fix in next version.
Thanks
-Xie
Ian.
.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
