Re: [Xen-devel] [PATCH v4 02/34] libxc: Remove dead code (XENVER_capabilities)

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 15, 2016 at 01:56:24PM -0400, Konrad Rzeszutek Wilk wrote:
> The 'caps' is not used anywhere in there.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> ---
>  tools/libxc/xc_dom_x86.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> index bdec40a..021f8a8 100644
> --- a/tools/libxc/xc_dom_x86.c
> +++ b/tools/libxc/xc_dom_x86.c
> @@ -1259,7 +1259,6 @@ static int meminit_hvm(struct xc_dom_image *dom)
>      unsigned long target_pages = dom->target_pages;
>      unsigned long cur_pages, cur_pfn;
>      int rc;
> -    xen_capabilities_info_t caps;
>      unsigned long stat_normal_pages = 0, stat_2mb_pages = 0, 
>          stat_1gb_pages = 0;
>      unsigned int memflags = 0;
> @@ -1339,12 +1338,6 @@ static int meminit_hvm(struct xc_dom_image *dom)
>          goto error_out;
>      }
>  
> -    if ( xc_version(xch, XENVER_capabilities, &caps) != 0 )
> -    {
> -        DOMPRINTF("Could not get Xen capabilities");
> -        goto error_out;
> -    }
> -
>      dom->p2m_size = p2m_size;
>      dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) *
>                                        dom->p2m_size);
> -- 
> 2.5.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel