Re: [Xen-devel] [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.16 at 13:54, <cardoe@xxxxxxxxxx> wrote:
> On 3/16/16 3:47 AM, Jan Beulich wrote:
>>>>> On 15.03.16 at 21:18, <cardoe@xxxxxxxxxx> wrote:
>>> Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM
>>> option allowing users to build Xen without tmem support.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>>> ---
>>> CC: Keir Fraser <keir@xxxxxxx>
>>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>>> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>>
>>> changes from v1:
>>> - add description provided by Konrad (thanks!)
>>> - tweaks to Makefile suggested by Jan
>> 
>> Only kind of:
>> 
>>> @@ -65,7 +63,12 @@ obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 
>>> unxz 
> unlzma unlzo unlz4
>>>  obj-$(perfc)       += perfc.o
>>>  obj-$(crash_debug) += gdbstub.o
>>>  
>>> -obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o 
> multicall.o tmem_xen.o xlat.o)
>>> +obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o 
> multicall.o xlat.o)
>>> +
>>> +tmem-y += tmem.o
>>> +tmem-y += tmem_xen.o
>> 
>> I had intentionally suggested
>> 
>> tmem-y := tmem.o tmem_xen.o
>> 
>> Splitting this up into two lines is a matter of taste, but not using := is
>> inefficient, as it requires make to possibly expand the variable many
>> times instead of just once.
>> 
>> But anyway - since functionality wise this is fine, with or without that
>> further adjustment
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> Jan
>> 
> 
> You're right. Its worth correcting. I'll post a v3. Can I retain your
> Acked-by?

Sure - I had said so already (see above).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel