[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [GRUB2 PATCH v4 1/4] i386/relocator: Add grub_relocator64_efi relocator



Other than 2 typos (inline). Looks good. Let's give it a day if somebody wants to object, then I'll commit it

        movq    %rax, %rsp

+       /*
+        * Here is grub_relocator64_efi_start() entry point.
+        * Following code is shared between grub_relocator64_efi_start()
+        * and grub_relocator64_start().
+        *
+        * Think twice before changing anything below!!!
+        */
above? 
+       /* Here grub_relocator64_efi_start() ends. Ufff... */
+VARIABLE(grub_relocator64_efi_end)
+
Probably without _start. Comment probably applies even more here than above.
 Are you ok with me moving ends to the same place when comitting?  This would make the code less error-prone.


--
Regards
Vladimir 'phcoder' Serbinenko

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.