Re: [Xen-devel] [PATCH 2/3] xen: sched RTDS: use uint64_t for tracing time values

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.03.16 at 12:34, <dario.faggioli@xxxxxxxxxx> wrote:
> --- a/xen/common/sched_rt.c
> +++ b/xen/common/sched_rt.c
> @@ -361,17 +361,14 @@ rt_update_deadline(s_time_t now, struct rt_vcpu *svc)
>  
>      /* TRACE */
>      {
> -        struct {
> +        struct __packed {
>              unsigned vcpu:16, dom:16;
> -            unsigned cur_deadline_lo, cur_deadline_hi;
> -            unsigned cur_budget_lo, cur_budget_hi;
> +            uint64_t cur_deadline, cur_budget;
>          } d;
>          d.dom = svc->vcpu->domain->domain_id;
>          d.vcpu = svc->vcpu->vcpu_id;
> -        d.cur_deadline_lo = (unsigned) svc->cur_deadline;
> -        d.cur_deadline_hi = (unsigned) (svc->cur_deadline >> 32);
> -        d.cur_budget_lo = (unsigned) svc->cur_budget;
> -        d.cur_budget_hi = (unsigned) (svc->cur_budget >> 32);
> +        d.cur_deadline = (uint64_t) svc->cur_deadline;
> +        d.cur_budget = (uint64_t) svc->cur_budget;

I don't see the need for these cast (and similar ones further down),
but you're the maintainer, so you know ...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel