Re: [Xen-devel] [PATCH v3 06/16] libxl: Load guest ACPI table from file

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 03, 2016 at 05:12:07PM +0000, Anthony PERARD wrote:
> On Tue, Mar 01, 2016 at 11:51:43AM +0000, Wei Liu wrote:
> > On Thu, Feb 25, 2016 at 02:56:04PM +0000, Anthony PERARD wrote:
> > > A user can provide a different ACPI tables than the default one by using
> > > the existing "acpi_firmware" xl's config option or the field
> > > u.hvm.acpi_firmware.
> > > 
> > > libxl will check if the provided table is a DSDT or not.
> > > 
> > 
> > According to xl.cfg manpage, acpi_firmware= cann't be used to override
> > DSDT, so you seem to be changing the semantics of existing option.
> 
> Yes, that was an idea from Ian Campbell <1446634655.6461.48.camel@xxxxxxxxxx>
> I should at least change the manual.
> 
> Would it be OK to reuse this options? Or should I add a new option, maybe
> acpi_dsdt_override, or some other name?
> 

If repurposing the old option won't break existing guest then that's
fine, otherwise a new option is required.

Wei.

> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel