Re: [Xen-devel] [PATCH v3 04/16] firmware/makefile: install BIOS and ACPI blob ...

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Feb 29, 2016 at 09:31:11AM -0700, Jan Beulich wrote:
> >>> On 25.02.16 at 15:56, <anthony.perard@xxxxxxxxxx> wrote:
> > @@ -42,12 +42,19 @@ dsdt_%cpu.asl: dsdt.asl mk_dsdt
> >     awk 'NR > 1 {print s} {s=$$0}' $< > $@
> >     ./mk_dsdt --debug=$(debug) --maxcpu $*  >> $@
> >  
> > -$(filter dsdt_%.c,$(C_SRC)): %.c: iasl %.asl
> > +$(filter dsdt_%cpu.c,$(C_SRC)): %.c: iasl %.asl
> 
> Would there be anything wrong with leaving this alone and ...
> 
> >     iasl -vs -p $* -tc $*.asl
> >     sed -e 's/AmlCode/$*/g' $*.hex >$@
> >     echo "int $*_len=sizeof($*);" >>$@
> >     rm -f $*.aml $*.hex
> 
> ... simply dropping the deletion of $*.aml here, plus ...
> 
> > +dsdt_anycpu_qemu_xen.c: dsdt_anycpu_qemu_xen.aml
> 
> ... an equivalent of this added?
> 
> > +dsdt_anycpu_qemu_xen.aml: %.aml: iasl %.asl
> > +   iasl -vs -p $* -tc $*.asl
> 
> Otherwise, if this is the rule to remain long term, then please make
> use of $< here, which aiui would require flipping around the two
> dependencies.

Yes, this rules is here to stay. The dsdt_anycpu_qemu_xen.c won't be needed
anymore after the patch series. The rule change in patch #14. I will use
$<.

> Whichever route you chose, with a respective adjustment
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel