Re: [Xen-devel] [V2] x86/xsaves: calculate the xstate_comp_offsets base on xcomp_bv

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.03.16 at 10:40, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 03, 2016 at 01:45:03AM -0700, Jan Beulich wrote:
>> > @@ -134,16 +143,19 @@ static void __init setup_xstate_comp(void)
>> >       */
>> >      xstate_comp_offsets[1] = XSAVE_SSE_OFFSET;
>> >  
>> >      xstate_comp_offsets[2] = FXSAVE_SIZE + XSAVE_HDR_SIZE;
>> >  
>> >      for ( i = 3; i < xstate_features; i++ )
>> >      {
>> > -        xstate_comp_offsets[i] = xstate_comp_offsets[i - 1] +
>> > -                                 (((1ul << i) & xfeature_mask)
>> > -                                  ? xstate_sizes[i - 1] : 0);
>> > +        xstate_comp_offsets[i] = (xstate_align[i] ?
>> > +                                 ROUNDUP(xstate_comp_offsets[i-1], 64) :
>> 
>> The coding style issue here persists too.
> In the previous comment, I think you mentions this
> coding style issue is the second line is not align with first line.
> Obviously, I misunderstand your meaning.
> Can give me corret coding style when encounter such case? For If I put
> the ROUNDUP in the first line it will go beyond 80 characters.
> Also I see CODING_STYLE file there is  "split in sensible places".May be
> I spilt in nonsensible place.

No, the splitting isn't the issue (or at least not the one I've noticed).
It's the lack of blanks around the - (which all other uses around here
have properly in place).

With the other comment I gave indentation and/or line splitting
would change anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel