Re: [Xen-devel] [PATCH v4 15/24] arm/acpi: Prepare EFI memory descriptor for Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.03.16 at 15:57, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Tue, 1 Mar 2016, Shannon Zhao wrote:
>> On 2016/2/29 22:37, Stefano Stabellini wrote:
>> > On Sun, 28 Feb 2016, Shannon Zhao wrote:
>> >> > --- a/xen/common/efi/boot.c
>> >> > +++ b/xen/common/efi/boot.c
>> >> > @@ -1233,6 +1233,44 @@ void __init acpi_create_efi_system_table(paddr_t 
>> >> > paddr, void *efi_acpi_table,
>> >> >      tbl_add[TBL_EFIT].start = table_addr;
>> >> >      tbl_add[TBL_EFIT].size = table_size;
>> >> >  }
>> >> > +
>> >> > +void __init acpi_create_efi_mmap_table(paddr_t paddr, paddr_t size,
>> >> > +                                       void *efi_acpi_table,
>> >> > +                                       const struct meminfo *mem,
>> >> > +                                       struct membank tbl_add[])
>> > This function probably belongs to xen/arch/arm/domain_build.c or
>> > arch/arm/efi
>> > 
>> As said before at previous patch set, placing these functions in
>> common/efi/boot.c is to use the EFI_MEMORY_DESCRIPTOR etc.
>> 
>> See
>> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg00097.html 
> 
> Sorry Shannon, I forgot about it.
> 
> 
>> But I agree that it cloud be moved to a new file(e.g. dom0-efi.c) under
>> arch/arm/efi.
> 
> Given the limitations, it would be acceptable to have the function here,

Afaic, having it in xen/common/efi/ is a no-go (we be acceptable
only it we were really just taking of one relatively small function,
but more gets added here by other patches), hence ...

> but given that this is about acpi and only useful on ARM, adding the
> function to a file under arch/arm/efi would be even better.

... this seems the only viable alternative.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel