Re: [Xen-devel] [PATCH 1/8] tools/xenalyze: Close symbol_file after reading it

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Feb 26, 2016 at 12:22:39PM +0000, Ian Jackson wrote:
> George Dunlap writes ("[PATCH 1/8] tools/xenalyze: Close symbol_file after 
> reading it"):
> > ...to avoid leaking the FD and associated memory.
> > 
> > CID 1306872
> > 
> > Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

And applied.
> 
> > Not sure if this will actually make coverity happy, or if we need to
> > actually set symbol_file to NULL.
> 
> I don't see why you'd need to assign to the symbol_file local (which
> is about to go out of scope).
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel