[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: initialise rc in libxl__domain_save error path



On Sat, Feb 27, 2016 at 9:30 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> Commit 7449fb36 ("migration/save: pass checkpointed_stream from libxl to
> libxc ") failed to initialise rc in the error path.
>
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed and applied.
> ---
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_dom_save.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl/libxl_dom_save.c
> index 4eb7960..f3288b9 100644
> --- a/tools/libxl/libxl_dom_save.c
> +++ b/tools/libxl/libxl_dom_save.c
> @@ -341,6 +341,7 @@ void libxl__domain_save(libxl__egc *egc, 
> libxl__domain_save_state *dss)
>      if (dss->checkpointed_stream != LIBXL_CHECKPOINTED_STREAM_NONE && 
> !r_info) {
>          LOG(ERROR, "Migration stream is checkpointed, but there's no "
>                     "checkpoint info!");
> +        rc = ERROR_INVAL;
>          goto out;
>      }
>
> --
> 2.1.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.